Implement missing context methods#363
Merged
codeboten merged 3 commits intoopen-telemetry:mainfrom Apr 7, 2021
Merged
Conversation
Contributor
|
Nice - for some reason I thought this would be more difficult. |
codeboten
approved these changes
Apr 7, 2021
Contributor
codeboten
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #321
Description
I am not an expert in gRPC, but I think this should fix this issue. I did this:
.../grpc/examples/python/helloworld(both these files are pretty much copy and paste of this:server.py
client.py
I ran
python server.pyandpython client.pyin separate consoles with the activated virtual environment before and I got this output:python server.pypython client.pyWithout these changes I would end up getting the error reported in #321 when I ran
client.py.Fixes #321
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.