Fix ASGI instrumentation default span name

[adamantike]

Description

Fixes ASGI default span name for SERVER spans, to be HTTP <method>.

Fixes #146.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Updated unit tests, executed with tox -e test-instrumentation-asgi.

Does This PR Require a Core Repo Change?

• No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

• Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been added
• Documentation has been updated

[lzchen]

scope["type"].receive is not defined in the specs. I am wondering what we should do with these spans.
@codeboten thoughts?

[codeboten]

im wondering if the SpanKind should be set here in addition to having the name of the span reflect the sender/receiver as per the messaging semantic conventions: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/messaging.md#span-name

[lzchen]

@adamantike
According to the specs, we should use a space instead of a period to separate destination name and operation name.

@codeboten
I think we actually should do that, following the specs, however might be out of scope for this pr.

[lzchen]

@adamantike
Any updates on this PR?

[adamantike]

@lzchen, sorry for the delay, I was waiting for a follow-up regarding the comment on scope["type"].receive.

I have rebased, and applied your other comment.

[codeboten]

@adamantike apologies for the delay, i completely missed this in my notifications.

[codeboten]

@adamantike have you had a chance to look at @lzchen's comment?

[adamantike]

@lzchen @codeboten, I have replaced the separator for destination and operation names. Please, let me know if that's what we expect based on the specs.

[lzchen]

Looks good. Please rebase.

[adamantike]

Rebased and fixed conflicts!

[lzchen]

@adamantike

Please fix the lint issues, then we can merge this :)

[adamantike]

Can it be that the CI error on the lint stage is failing globally for all PRs? It seems opentelemetry-test has been removed from PyPI:

lint run-test-pre: commands[37] | python -m pip install -e '/home/runner/work/opentelemetry-python-contrib/opentelemetry-python-contrib/instrumentation/opentelemetry-instrumentation-tornado[test]'
Obtaining file:///home/runner/work/opentelemetry-python-contrib/opentelemetry-python-contrib/instrumentation/opentelemetry-instrumentation-tornado
Collecting tornado>=6.0
  Downloading tornado-6.1-cp38-cp38-manylinux2010_x86_64.whl (427 kB)
Collecting opentelemetry-instrumentation==0.21b0
  Downloading opentelemetry_instrumentation-0.21b0-py3-none-any.whl (16 kB)
Collecting opentelemetry-api==1.2.0
  Downloading opentelemetry_api-1.2.0-py3-none-any.whl (37 kB)
Collecting opentelemetry-semantic-conventions==0.21b0
  Downloading opentelemetry_semantic_conventions-0.21b0-py3-none-any.whl (20 kB)
Collecting opentelemetry-util-http==0.21b0
  Downloading opentelemetry_util_http-0.21b0-py3-none-any.whl (3.6 kB)
ERROR: Could not find a version that satisfies the requirement opentelemetry-test==0.21b0 (from opentelemetry-instrumentation-tornado[test]) (from versions: none)
ERROR: No matching distribution found for opentelemetry-test==0.21b0
ERROR: InvocationError for command /home/runner/work/opentelemetry-python-contrib/opentelemetry-python-contrib/.tox/lint/bin/python -m pip install -e '/home/runner/work/opentelemetry-python-contrib/opentelemetry-python-contrib/instrumentation/opentelemetry-instrumentation-tornado[test]' (exited with code 1)

[lzchen]

Ahh I see, should be fixed after this.