Request/Response hooks for Tornado server and client#422
Closed
owais wants to merge 1 commit intoopen-telemetry:mainfrom
Closed
Request/Response hooks for Tornado server and client#422owais wants to merge 1 commit intoopen-telemetry:mainfrom
owais wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
owais
force-pushed
the
tornado-hooks
branch
8 times, most recently
from
40ffd21 to
13797d9
Compare
owais
requested review from
a team,
codeboten and
lzchen
and removed request for
a team
owais
force-pushed
the
tornado-hooks
branch
5 times, most recently
from
87c8272 to
fc0979b
Compare
Contributor
Author
|
CI has been stuck and isn't working no matter what I try. Closing the PR and opening another one: #426 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for request and response hooks to Falcon instrumentation. Given how tornado works, we only have a single hook that gets called once per request. It gets passed the active handler instead of request/response objects.
Fixes #132
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.