Add SQLAlchemy multithreading test#468
Merged
codeboten merged 3 commits intoopen-telemetry:mainfrom Jun 3, 2021
jomasti:sqlalchemy-multithreading-test
Merged
Add SQLAlchemy multithreading test#468codeboten merged 3 commits intoopen-telemetry:mainfrom jomasti:sqlalchemy-multithreading-test
codeboten merged 3 commits intoopen-telemetry:mainfrom
jomasti:sqlalchemy-multithreading-test
Conversation
jomasti
requested review from
a team,
codeboten and
ocelotl
and removed request for
a team
codeboten
reviewed
May 4, 2021
tests/opentelemetry-docker-tests/tests/sqlalchemy_tests/mixins.py
Outdated
Show resolved
Hide resolved
ocelotl
suggested changes
May 27, 2021
tests/opentelemetry-docker-tests/tests/sqlalchemy_tests/mixins.py
Outdated
Show resolved
Hide resolved
tests/opentelemetry-docker-tests/tests/sqlalchemy_tests/test_sqlite.py
Outdated
Show resolved
Hide resolved
I was able to get the test to fail reliably for PostgreSQL by reverting back the behavior before #315. When going back to the current behavior, the test passes fine. Should more be done to try to trigger the others to also log the warning?
ocelotl
approved these changes
Jun 2, 2021
codeboten
approved these changes
Jun 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I was able to get the test to fail reliably for PostgreSQL by reverting
back the behavior before #315. When going back to the current behavior,
the test passes fine.
Should more be done to try to trigger the others
to also log the warning?
Resolves #383
Type of change
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.