Fix pyodbc cursor error in SQLA instrumentation#469
Merged
codeboten merged 9 commits intoopen-telemetry:mainfrom Jun 7, 2021
jomasti:sqlalchemy-pyodbc-cursor-error
Merged
Fix pyodbc cursor error in SQLA instrumentation#469codeboten merged 9 commits intoopen-telemetry:mainfrom jomasti:sqlalchemy-pyodbc-cursor-error
codeboten merged 9 commits intoopen-telemetry:mainfrom
jomasti:sqlalchemy-pyodbc-cursor-error
Conversation
jomasti
requested review from
a team,
aabmass and
hectorhdzg
and removed request for
a team
ocelotl
previously approved these changes
May 27, 2021
tests/opentelemetry-docker-tests/tests/sqlalchemy_tests/test_mssql.py
Outdated
Show resolved
Hide resolved
Contributor
|
Please take a look at the failing test case, @jomasti |
Deleting the cursor reference after execution and in the error handler instead of keeping a weak reference. Added Docker tests for MSSQL and pyodbc to verify the instrumentation as working
ocelotl
approved these changes
Jun 2, 2021
jomasti
changed the title
codeboten
approved these changes
Jun 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deleting the cursor reference after execution and in the error handler
instead of keeping a weak reference.
Fixes #460
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
working
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.