Move instrumentation grpc#59
Closed
NathanielRN wants to merge 10 commits intoopen-telemetry:masterfrom
Closed
Conversation
…etry#1027) * when running the grpc tests with pytest or eachdist from the command line the 2nd test trying to connect to the test server failed with a connection refused message. Seems like the connection from the previous test was still alive due to the channel not being properly closed.
* dropping support for python 3.4
As far as I can tell, the tutorial in the docs doesn't actually work without this line.
* updating changelogs and version to 0.13b0
This was referenced Oct 21, 2020
Member
|
It looks like there's some big changes coming in from the original repo: open-telemetry/opentelemetry-python#1308. Should we wait for those to settle first? |
Contributor
Author
|
@toumorokoshi Yes definitely agree with that. Thanks for your quick review on it! I think best case scenario we should iterate quickly on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves the
instrumentation/opentelemetry-instrumentation-grpcfrom the core repo into the contrib repo.The original code is being copied over from the Core repo here: https://github.com/open-telemetry/opentelemetry-python/tree/master/instrumentation/opentelemetry-instrumentation-grpc
How Has This Been Tested?
CI tests will confirm it works correctly.
The only reason I didn't add tests yet (and I didn't plan to until we get all the packages we want in) is because the tests introduced here depend on other packages that will be coming (very soon hopefully!) in future PRs.
After the PRs with the packages are merged, I'll take the same approach I took in my large PR #47 where I got the tests to pass.
Checklist:
- [ ] Changelogs have been updated- [ ] Unit tests have been added- [ ] Documentation has been updated