Added new opentelemetry-contrib-instrumentations meta package

[owais]

Description

This package does not contain any features on its own but serves is a
convenient way to install all supported instrumentations at once.

Also pins markupsafe to 2.0.1 in tests as 2.1.1 adding some breaking changes.

Type of change

Please delete options that are not relevant.

• New package
• Packaging fix

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Manually

Does This PR Require a Core Repo Change?

• Yes. - Link to PR:
• No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

• Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been added
• Documentation has been updated

[codeboten]

@owais we've come full circle 🤣 open-telemetry/opentelemetry-python#605

[owais]

haha. I didn't know we considered it before I did not remember that. I think it is a lot more viable now that we don't pull in the frameworks we instrument with the instrumentations.

[ocelotl]

I am not sure this idea will age well. In some time there possibly will be other instrumentations developed by third parties and hosted in other repos. If that happens, should we rename this to opentelemetry-instrumentation-some? What if then someone releases the Some framework? How will we name the instrumentation for this framework?

Also, who is the intended end user? Someone who has a virtual environment where instrumentation for many frameworks happen?

[owais]

I am not sure this idea will age well. In some time there possibly will be other instrumentations developed by third parties and hosted in other repos. If that happens, should we rename this to opentelemetry-instrumentation-some? What if then someone releases the Some framework? How will we name the instrumentation for this framework?

If it is an officially supported package by Python OpenTelemetry i.e, lives in the contrib repo then it'll be added as a dependency. Any 3rd party packages hosted by others on their own will not be added.

Also, who is the intended end user? Someone who has a virtual environment where instrumentation for many frameworks happen?

People who cannot or don't want to use an additional command (bootstrap) to install instrumentation packages and vendors who want to ship a UX where everything is bundled by default to reduce manual steps.

[owais]

Perhaps opentelemetry-contrib-instrumentations would be a better name?

[ocelotl]

Perhaps opentelemetry-contrib-instrumentations would be a better name?

Yes, much better 👍

[lzchen]

@owais
Are you still working on this PR?

[owais]

I wanted to work on the opentelemetry package first but that got considerable push back. I'll revive this one next week.

[owais]

@lzchen @ocelotl updated the PR with simpler implementation

[lzchen]

I wanted to work on the opentelemetry package first but that got considerable push back.

Curious, what was the pushback related to for this?

I think it is a lot more viable now that we don't pull in the frameworks we instrument with the instrumentations.

Was this the main issue for closing the previous PR?

[owais]

@ocelotl PTAL

[owais]

@ocelotl ping :)

[ocelotl]

@ocelotl ping :)

sorry! reviewing...

[phillipuniverse]

@owais @ocelotl it doesn't look like this got uploaded to Pypi? https://pypi.org/project/opentelemetry-contrib-instrumentations/

[lzchen]

@phillipuniverse
My mistake, looks like it wasn't automatically released as part of the build. Will releasing shortly.

[lzchen]

@phillipuniverse
https://pypi.org/project/opentelemetry-contrib-instrumentations/0.30b0/

[phillipuniverse]

awesome, thanks @lzchen!!