Merged
Conversation
ItayGibel-helios
force-pushed
the
pika_hooks
branch
from
92fc2e2 to
f9a25d1
Compare
Member
oxeye-nikolay
left a comment
oxeye-nikolay
left a comment
There was a problem hiding this comment.
Please ensure you don't add opentelemetry-python-core as it is not needed anymore, and isn't a part of this repo
...mentation/opentelemetry-instrumentation-pika/src/opentelemetry/instrumentation/pika/utils.py
Outdated
Show resolved
Hide resolved
...mentation/opentelemetry-instrumentation-pika/src/opentelemetry/instrumentation/pika/utils.py
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-pika/tests/test_utils.py
Outdated
Show resolved
Hide resolved
Member
|
Also, Please update the |
...mentation/opentelemetry-instrumentation-pika/src/opentelemetry/instrumentation/pika/utils.py
Outdated
Show resolved
Hide resolved
ItayGibel-helios
force-pushed
the
pika_hooks
branch
2 times, most recently
from
14c47c2 to
2c9341d
Compare
...mentation/opentelemetry-instrumentation-pika/src/opentelemetry/instrumentation/pika/utils.py
Show resolved
Hide resolved
oxeye-nikolay
approved these changes
Oct 21, 2021
ItayGibel-helios
force-pushed
the
pika_hooks
branch
from
d3cefff to
b8e666b
Compare
lzchen
reviewed
Oct 21, 2021
|
|
||
| PikaInstrumentor.instrument_channel(channel, tracer_provider=tracer_provider) | ||
|
|
||
| * PikaInstrumentor also supports instrumenting with hooks that will be called when producing or consuming a message. |
Contributor
There was a problem hiding this comment.
Please include these docs as part of the docstrings in __init__.py only. We want only one source of truth for docs.
ItayGibel-helios
force-pushed
the
pika_hooks
branch
from
1bd4ed4 to
37aac19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding consume_hook and produce_hook to Pika instrumentor
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist: