Skip to content

adding unit test case for ASGI framework for application wrapped with…#899

Merged
owais merged 5 commits intoopen-telemetry:mainfrom
sanketmehta28:develop/conditional_server_span_asgi
Feb 3, 2022
Merged

adding unit test case for ASGI framework for application wrapped with…#899
owais merged 5 commits intoopen-telemetry:mainfrom
sanketmehta28:develop/conditional_server_span_asgi

Conversation

@sanketmehta28
Copy link
Member

Description

This PR includes a unit test case for PR
Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Test A: Ran the full pytest for asgi framwork

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Unit tests have been added

@sanketmehta28 sanketmehta28 requested a review from a team February 3, 2022 16:18
@sanketmehta28
Copy link
Member Author

HI, Can we skip the changelog for this PR? I have added the unit test missed in PR

@owais owais added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 3, 2022
@ocelotl
Copy link
Contributor

ocelotl commented Feb 3, 2022

Looks good, please read the logs of the generate test case ✌️

@sanketmehta28
Copy link
Member Author

@ocelotl : done and committed the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants