Added Falcon 2.0+ instrumentation#1039
Merged
codeboten merged 5 commits intoopen-telemetry:masterfrom Sep 16, 2020
Merged
Conversation
owais
force-pushed
the
falcon-instrumentation
branch
12 times, most recently
from
1ad6ea6 to
dca4987
Compare
codeboten
suggested changes
Aug 26, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
This PR looks pretty good, just a couple of things that need to be fixed.
opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap.py
Show resolved
Hide resolved
opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap.py
Show resolved
Hide resolved
codeboten
added
the
instrumentation
Contributor
Author
|
@open-telemetry/python-approvers would appreciate if someone could help review this. |
owais
force-pushed
the
falcon-instrumentation
branch
from
47fc481 to
7e84041
Compare
ocelotl
approved these changes
Sep 10, 2020
Comment on lines
+28
to
+32
| entry_points={ | ||
| "opentelemetry_instrumentor": [ | ||
| "falcon = opentelemetry.instrumentation.falcon:FalconInstrumentor" | ||
| ] | ||
| }, |
Contributor
There was a problem hiding this comment.
This can be moved to setup.cfg.
| try: | ||
| return super().__call__(env, _start_response) | ||
| except Exception as exc: | ||
| activation.__exit__( |
Contributor
There was a problem hiding this comment.
I am assuming that line 132 ends up calling _start_response. What if an exception is raised during the execution of start_response inside _start_response? Would that exception be caught here and activation.__exit__ end up being called twice?
Contributor
Author
There was a problem hiding this comment.
Good catch. Fixed to call exit after start_response finishes.
| FalconInstrumentor().uninstrument() | ||
|
|
||
| def test_methods(self): | ||
| for method in ["GET", "POST", "PATCH", "PUT", "DELETE", "HEAD"]: |
Contributor
There was a problem hiding this comment.
Just as a comment, it can be worthy to have this separated in a test_X method for every method, so that if one of these tests fail, it gets reported in the results which method failed.
owais
force-pushed
the
falcon-instrumentation
branch
4 times, most recently
from
358d78c to
511c0d6
Compare
owais
force-pushed
the
falcon-instrumentation
branch
from
511c0d6 to
678f27e
Compare
8 tasks
alertedsnake
pushed a commit
to alertedsnake/opentelemetry-python
that referenced
this pull request
Sep 25, 2020
adamantike
added a commit
to adamantike/opentelemetry-python-contrib
that referenced
this pull request
Oct 25, 2021
Remove unwanted support for Python versions <3.6. This integration mistakenly lists Python 3.4 support, because it was merged in open-telemetry/opentelemetry-python#1039, after the merge of open-telemetry/opentelemetry-python#1099, so the latter didn't consider `falcon`. Python 3.4 is broken nevertheless, as this integration already includes f-strings and other `opentelemetry` dependencies, which require Python 3.6. Fixes open-telemetry#772.
6 tasks
adamantike
added a commit
to adamantike/opentelemetry-python-contrib
that referenced
this pull request
Oct 25, 2021
Remove unwanted support for Python versions <3.6. This integration mistakenly lists Python 3.4 support, because it was merged in open-telemetry/opentelemetry-python#1039, after the merge of open-telemetry/opentelemetry-python#1099, so the latter didn't consider `falcon`. Python 3.4 is broken nevertheless, as this integration already includes f-strings and other `opentelemetry` dependencies, which require Python 3.6. Fixes open-telemetry#772.
owais
pushed a commit
to open-telemetry/opentelemetry-python-contrib
that referenced
this pull request
Oct 25, 2021
Remove unwanted support for Python versions <3.6. This integration mistakenly lists Python 3.4 support, because it was merged in open-telemetry/opentelemetry-python#1039, after the merge of open-telemetry/opentelemetry-python#1099, so the latter didn't consider `falcon`. Python 3.4 is broken nevertheless, as this integration already includes f-strings and other `opentelemetry` dependencies, which require Python 3.6. Fixes #772.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add instrumentation for Falcon 2.0+
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: