Make propagators a namespace#1591
Merged
lzchen merged 12 commits intoopen-telemetry:mainfrom Feb 16, 2021
Merged
Conversation
ocelotl
requested review from
a team,
aabmass and
codeboten
and removed request for
a team
lzchen
reviewed
Feb 9, 2021
opentelemetry-api/tests/propagators/test_global_httptextformat.py
Outdated
Show resolved
Hide resolved
ocelotl
force-pushed
the
issue_1590
branch
5 times, most recently
from
d151f56 to
4c7bbf7
Compare
lzchen
reviewed
Feb 12, 2021
lzchen
approved these changes
Feb 12, 2021
codeboten
reviewed
Feb 13, 2021
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
I think the changes here are ok. I'm curious though, it feels weird to have to import a util package for the only methods in propagators that we care about inject & extract
Any thoughts?
Contributor
Author
|
Contributor
Author
Yes, it is weird. How about renaming |
ocelotl
force-pushed
the
issue_1590
branch
2 times, most recently
from
226fbfb to
149fa2b
Compare
codeboten
approved these changes
Feb 16, 2021
This is needed to make the PR pass its tests in CI. This requires the version to be updated back later in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1590
Makes propagators a namespace so that we can have proper propagators in the contrib repo as well as here.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/The method interfaces of
opentelemetry-instrumentation/have changedThe method interfaces of
test/utilhave changedScripts in
scripts/that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.tomlisort.cfg.flake8When a new
.github/CODEOWNERis addedMajor changes to project information, such as in:
README.mdCONTRIBUTING.mdYes. - Link to PR: Add OpenTracing propagator opentelemetry-python-contrib#302
No.
Checklist: