Merged
Conversation
…y-python into remove_service_name
srikanthccv
reviewed
Mar 4, 2021
Member
srikanthccv
left a comment
There was a problem hiding this comment.
@dmarar Thanks for picking this up. I believe we should also remove the OTEL_PYTHON_SERVICE_NAME and service name in auto instrumentation.
exporter/opentelemetry-exporter-jaeger/src/opentelemetry/exporter/jaeger/__init__.py
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-jaeger/tests/test_jaeger_exporter_protobuf.py
Show resolved
Hide resolved
exporter/opentelemetry-exporter-jaeger/tests/test_jaeger_exporter_thrift.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks @lonewolf3739 . Will work on this. |
owais
reviewed
Mar 6, 2021
exporter/opentelemetry-exporter-jaeger/src/opentelemetry/exporter/jaeger/__init__.py
Outdated
Show resolved
Hide resolved
...lemetry-exporter-opencensus/src/opentelemetry/exporter/opencensus/trace_exporter/__init__.py
Outdated
Show resolved
Hide resolved
modified distro and distro tests to get service_name from Resouce
…y-python into remove_service_name
dmarar
commented
Mar 8, 2021
…y-python into remove_service_name
…elemetry-python into remove_service_name
Contributor
My mistake, I thought you meant it was ALREADY removed prior to this PR. Ignore my comment :) |
dmarar
commented
Mar 12, 2021
exporter/opentelemetry-exporter-jaeger/tests/test_jaeger_exporter_thrift.py
Show resolved
Hide resolved
Contributor
Author
|
@owais I'm not able to add you as 3rd reviewer. I have made the changes you suggested. |
srikanthccv
reviewed
Mar 15, 2021
lzchen
reviewed
Mar 15, 2021
exporter/opentelemetry-exporter-jaeger/tests/test_jaeger_exporter_protobuf.py
Outdated
Show resolved
Hide resolved
lzchen
approved these changes
Mar 15, 2021
Contributor
Author
Contributor
|
@owais can you confirm your comments have been addressed |
codeboten
approved these changes
Mar 16, 2021
codeboten
pushed a commit
to codeboten/opentelemetry-python
that referenced
this pull request
Mar 16, 2021
codeboten
pushed a commit
that referenced
this pull request
Apr 2, 2021
Changes from #1669 have not been reflected in the docs
This was referenced May 22, 2021
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The service-name parameter from the constructors of exporters of Opencensus, jaeger was removed.
Instead the Resource's service.name attribute from Tracer/Span was used to get the service_name
Fixes # (issue)
#1607
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/The method interfaces of
opentelemetry-instrumentation/have changedThe method interfaces of
test/utilhave changedScripts in
scripts/that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.tomlisort.cfg.flake8When a new
.github/CODEOWNERis addedMajor changes to project information, such as in:
README.mdCONTRIBUTING.mdYes. - Link to PR:
No.
Checklist: