add schema_url to TracerProvider.get_tracer#2154
Merged
ocelotl merged 11 commits intoopen-telemetry:mainfrom Sep 29, 2021
Merged
add schema_url to TracerProvider.get_tracer#2154ocelotl merged 11 commits intoopen-telemetry:mainfrom
schema_url to TracerProvider.get_tracer#2154ocelotl merged 11 commits intoopen-telemetry:mainfrom
Conversation
codeboten
reviewed
Sep 25, 2021
exporter/opentelemetry-exporter-jaeger-proto-grpc/tests/test_jaeger_exporter_protobuf.py
Outdated
Show resolved
Hide resolved
codeboten
reviewed
Sep 27, 2021
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Thanks for address my comments, just one question left
lzchen
approved these changes
Sep 27, 2021
codeboten
approved these changes
Sep 28, 2021
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
👍 thanks for addressing my comments.
Contributor
|
@JamesJHPark please fix lint failures |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The specification of Tracing API in 1.4.0 added an optional parameter
schema_urlto the method,TracerProvider.get_tracer. This requires addition ofschema_urlfield inInstrumentationInfoclass and updates to API, SDK packages. Tests have been modified to implement and reflect the addition of the optional parameter.Fixes issue #1971
Type of change
How Has This Been Tested?
Tests have been implemented with
toxteststoxtestsDoes This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/No.
Checklist: