ReadableSpan events and links now return a tuple#2215
Merged
owais merged 6 commits intoopen-telemetry:mainfrom Oct 22, 2021
Merged
ReadableSpan events and links now return a tuple#2215owais merged 6 commits intoopen-telemetry:mainfrom
owais merged 6 commits intoopen-telemetry:mainfrom
Conversation
|
|
dd49d29 to
1de5c5b
Compare
owais
approved these changes
Oct 17, 2021
srikanthccv
approved these changes
Oct 17, 2021
Contributor
|
I think this PR needs a changelog entry ✌️ |
lzchen
approved these changes
Oct 18, 2021
auto-merge was automatically disabled
October 18, 2021 21:15
Head branch was pushed to by a user without write access
Removed MappingProxy since events and links are not mappings Signed-off-by: Ted Kern <tkern@arnatious.com>
1be9a6b to
48faadb
Compare
Contributor
Author
|
Added changelog entry! |
Contributor
|
Please fix lint and we can get this merged in, @Arnatious ✌️ |
auto-merge was automatically disabled
October 20, 2021 00:21
Head branch was pushed to by a user without write access
Contributor
Author
|
Re:fixed lint, looks like I missed whitespace first time. Separate issue I'll raise: |
Contributor
|
Here is how to fix
Commit the generated changes. |
aabmass
added a commit
that referenced
this pull request
Oct 29, 2021
* updating changelogs and version to 1.6.1-0.25b1 (#2223) * default value is invalid, was renamed (#2226) * Website: support GH page links to canonical src, and aliases (#2224) * Fix opentracing shim references (#2180) * Prepare release v1.6.2 and 0.25b2 (#2230) * update changelog to note the rename of entrypoints in 1.6.0 (#2228) * add note about proto version to README.rst (#2232) * ReadableSpan events and links now return a tuple (#2215) * ReadableSpan events and links now return a tuple Removed MappingProxy since events and links are not mappings Signed-off-by: Ted Kern <tkern@arnatious.com> * fix lint Signed-off-by: Ted Kern <tkern@arnatious.com> * fix lint * fix lint Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com> Co-authored-by: Leighton Chen <lechen@microsoft.com> * adding CI testing for python 3.10 (#2207) * remove `X-B3-ParentSpanId` for B3 propagator as per OpenTelemetry Specification (#2237) * remove X-B3-ParentSpanId for B3 propagator as per OpenTelemetry specification * revert changes - run tests * re-commit changes * add entry to CHANGELOG * remove ParentSpanId in B3SingleFormat * Remove lingering distro pkg files (#2241) Co-authored-by: Leighton Chen <lechen@microsoft.com> Co-authored-by: alrex <aboten@lightstep.com> Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Co-authored-by: Ben Roberts <robertsben@users.noreply.github.com> Co-authored-by: Owais Lone <owais@users.noreply.github.com> Co-authored-by: Ted Kern <tkern@arnatious.com> Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com> Co-authored-by: James <45812677+JamesJHPark@users.noreply.github.com> Co-authored-by: (Eliseo) Nathaniel Ruiz Nowell <nathanielruiz98@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ReadableSpan events and links attributes now return a sequence, as described, removing a TypeError.
No longer attempt to wrap Links and Events in
MappingProxy's since they are not descendants of Mapping likeAttributes.Fixes #2214
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
tox -e py38-opentelemetry-sdk -- trace/test_trace.py::TestReadableSpan(tested on Python 3.8.10 on Ubuntu on WSL2)Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/The method interfaces of
test/utilhave changedScripts in
scripts/that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.tomlisort.cfg.flake8When a new
.github/CODEOWNERis addedMajor changes to project information, such as in:
README.mdCONTRIBUTING.mdYes. - Link to PR:
No.
Checklist: