Merged
Conversation
Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
requested review from
Oberon00,
a-feld,
c24t,
carlosalberto,
lzchen,
reyang and
toumorokoshi
as code owners
c24t
approved these changes
Nov 27, 2019
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
=======================================
Coverage 85.76% 85.76%
=======================================
Files 33 33
Lines 1609 1609
Branches 180 180
=======================================
Hits 1380 1380
Misses 182 182
Partials 47 47Continue to review full report at Codecov.
|
Contributor
|
👍 |
lzchen
approved these changes
Nov 27, 2019
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
* feat(metrics): add types and base implementation * fix: styling * Update packages/opentelemetry-metrics/src/export/types.ts Make sum optional * fix: make sum optional * fix: use HrTime interface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help us catch linting problems sooner. See #308 for more details
Signed-off-by: Alex Boten aboten@lightstep.com