Add metrics base tests#3182
Merged
srikanthccv merged 5 commits intoopen-telemetry:mainfrom Feb 23, 2023
Merged
Conversation
6 tasks
srikanthccv
reviewed
Feb 18, 2023
tests/opentelemetry-test-utils/src/opentelemetry/test/test_base.py
Outdated
Show resolved
Hide resolved
srikanthccv
approved these changes
Feb 21, 2023
lzchen
reviewed
Feb 21, 2023
03f4a00 to
19c74b1
Compare
lzchen
approved these changes
Feb 22, 2023
This was referenced Feb 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move the metrics basic test to TestBase class so each metric instrumentation could use those functions
The functions moved from the sqlalchemy instrumentation test and used for urllib3, urllib, tornado:
open-telemetry/opentelemetry-python-contrib#1645
Refactored from:
#3092
Type of change
Please delete options that are not relevant.
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/The method interfaces of
test/utilhave changedScripts in
scripts/that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.tomlisort.cfg.flake8When a new
.github/CODEOWNERis addedMajor changes to project information, such as in:
README.mdCONTRIBUTING.mdYes. - Link to PR:
No.
Checklist: