Skip to content

feat(logs): implement log creation metric#4935

Merged
xrmx merged 6 commits intoopen-telemetry:mainfrom
anuraaga:logger-metrics
Mar 11, 2026
Merged

feat(logs): implement log creation metric#4935
xrmx merged 6 commits intoopen-telemetry:mainfrom
anuraaga:logger-metrics

Conversation

@anuraaga
Copy link
Contributor

Description

I am helping to implement SDK internal metrics

https://opentelemetry.io/docs/specs/semconv/otel/sdk-metrics/

This implements the metric for created logs. It is very similar to #4880 for spans.

/cc @xrmx to help with review

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@anuraaga anuraaga requested a review from a team as a code owner February 26, 2026 02:39
@xrmx xrmx moved this to Ready for review in Python PR digest Feb 26, 2026
@xrmx xrmx self-assigned this Feb 26, 2026
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small nit but LGTM

@xrmx xrmx moved this from Ready for review to Reviewed PRs that need fixes in Python PR digest Mar 3, 2026
Copy link
Contributor Author

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all - as a reminder this is almost identical to the merged PR for trace including the naming conventions. Let me know if we should go ahead and change the naming, and I would send another PR to reflect to tracing, or go with what we have.

Copy link
Contributor Author

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xrmx - I have applied the import fix and left the names as is since it sounds like that was OK

@xrmx xrmx requested a review from herin049 March 6, 2026 08:48
@herin049
Copy link
Contributor

Lgtm, we can update some of the naming conventions later.

@xrmx xrmx enabled auto-merge (squash) March 11, 2026 21:06
@xrmx xrmx merged commit 0f47f66 into open-telemetry:main Mar 11, 2026
450 checks passed
@github-project-automation github-project-automation bot moved this from Reviewed PRs that need fixes to Done in Python PR digest Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants