ext/requests - apply custom attributes callback#656
Merged
toumorokoshi merged 7 commits intoopen-telemetry:masterfrom May 11, 2020
Merged
ext/requests - apply custom attributes callback#656toumorokoshi merged 7 commits intoopen-telemetry:masterfrom
toumorokoshi merged 7 commits intoopen-telemetry:masterfrom
Conversation
toumorokoshi
suggested changes
May 8, 2020
Member
toumorokoshi
left a comment
There was a problem hiding this comment.
Thanks! The code looks good, just want to discuss the naming of the argument and make sure it's succinct.
ext/opentelemetry-ext-requests/src/opentelemetry/ext/requests/__init__.py
Outdated
Show resolved
Hide resolved
mauriciovasquezbernal
approved these changes
May 8, 2020
Member
mauriciovasquezbernal
left a comment
There was a problem hiding this comment.
LGTM, some minor comments.
I second @toumorokoshi about the callback name, it could be more generic. Approving now assuming you'll handle it :)
ext/opentelemetry-ext-requests/tests/test_requests_integration.py
Outdated
Show resolved
Hide resolved
ext/opentelemetry-ext-requests/tests/test_requests_integration.py
Outdated
Show resolved
Hide resolved
ext/opentelemetry-ext-requests/tests/test_requests_integration.py
Outdated
Show resolved
Hide resolved
ext/opentelemetry-ext-requests/src/opentelemetry/ext/requests/__init__.py
Show resolved
Hide resolved
ext/opentelemetry-ext-requests/tests/test_requests_integration.py
Outdated
Show resolved
Hide resolved
owais
pushed a commit
to owais/opentelemetry-python
that referenced
this pull request
May 22, 2020
Implement passing an optional span_callback callback when instrumenting requests. The callback will be called just before returning the result and will be invoked with the span and the result (type of requests.Response). This mimics the same functionality as the js http plugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements passing an optional
span_callbackcallback when instrumentingrequests.The callback will be called just before returning the result and will be invoked with the
spanand theresult(type of requests.Response).This mimics the same functionality as in js http plugin.
Example:
Please LMK if and what docs need to be updated.