api: Adding record_error to span API#790
Merged
toumorokoshi merged 24 commits intoopen-telemetry:masterfrom Jun 12, 2020
Merged
api: Adding record_error to span API#790toumorokoshi merged 24 commits intoopen-telemetry:masterfrom
toumorokoshi merged 24 commits intoopen-telemetry:masterfrom
Conversation
…ame opentelemetry-auto-instrumentation (open-telemetry#741)
The span context is no longer coupled with the tracer itself. As such, providing a get_current_span method bound to the trace api module rather than a specific tracer is semantically correct, and removes a hurdle where someone who wants to retrieve the current trace would have to create a tracer to do so. renaming and exporting get_span_in_context to get_current_span, as the intention of the API is similar, and reduces unneeded aliasing and duplication. set_span_in_context is not renamed, as set_current_span would have implied that the span would then be active in the default context, which is only true after attaching the resulting context returned by set_span_in_context. Keeping that name at least implies some asymmetric behavior from get_current_span. After discussion in the SIG, we decided to remove the legacy get_current_span APIs from Tracer and TracerProvider to reduce long-term confusion of how to idiomatically retrieve the span. Co-authored-by: alrex <aboten@lightstep.com> Co-authored-by: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com> Co-authored-by: Leighton Chen <lechen@microsoft.com> Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com> Co-authored-by: Mauricio Vásquez <mauricio@kinvolk.io> Co-authored-by: Andrew Xue <aaxue@google.com> Co-authored-by: Cheng-Lung Sung <clsung@gmail.com>
Initial addition of opentelemetry-proto based protobufs. Co-authored-by: alrex <alrex.boten@gmail.com> Co-authored-by: Yusuke Tsutsumi <yusuke@tsutsumi.io>
Adding an exporter that supports sending metrics data to cloud monitoring (formerly known as stackdriver). Co-authored-by: Chris Kleinknecht <libc@google.com> Co-authored-by: Yusuke Tsutsumi <yusuke@tsutsumi.io>
Adding initial boto core implementation. Co-authored-by: alrex <alrex.boten@gmail.com>
Co-authored-by: Yusuke Tsutsumi <yusuke@tsutsumi.io>
Co-authored-by: Yusuke Tsutsumi <yusuke@tsutsumi.io>
eachdist.py did not support the installation of test packages, (as defined by the extra_requires:test package group). As a result, test packages were being added to dev-requirements.txt By having eachdist.py develop install test packages, and moving develop/test package definitions to the individual instrumentations, it is easier to determine which packages require which dependencies for testing purposes, and enables support for existing dependencies that follow the extra_requires:test pattern.
Co-authored-by: Leighton Chen <lechen@microsoft.com> Co-authored-by: alrex <aboten@lightstep.com>
opentelemetry-test was not listed as a test dependency in the asgi instrumentation.
Minor cleanup of setup.cfg files. Updated the example app to move configuration from setup.py into setup.cfg as well. Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com> Co-authored-by: Yusuke Tsutsumi <yusuke@tsutsumi.io>
adding some troubleshooting tips for users with common failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per open-telemetry/opentelemetry-specification#427, we need an interface for users to record errors. This PR provides one possible solution to record the error as an event on the span.