Set span status on wsgi errors#864
Merged
codeboten merged 5 commits intoopen-telemetry:masterfrom Jul 7, 2020
Merged
Conversation
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Contributor
Author
|
Sorry about closing, wanted to make sure CLAs are checked. |
Contributor
Author
|
@codeboten thanks for the review! Is there a tool/command to add CHANGELOG entry? Also, maybe a good idea to mention about this in CONTRIBUTING.md? |
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
codeboten
approved these changes
Jul 7, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
LGTM, thanks for the changelog update!
codeboten
pushed a commit
that referenced
this pull request
Jul 7, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
INTERNALerror span status for unhandled uwsgi exceptions before calling span.end().Fixes #846