Rename web framework packages from "ext" to "instrumentation"#961
Merged
lzchen merged 38 commits intoopen-telemetry:masterfrom Aug 3, 2020
Merged
Rename web framework packages from "ext" to "instrumentation"#961lzchen merged 38 commits intoopen-telemetry:masterfrom
lzchen merged 38 commits intoopen-telemetry:masterfrom
Conversation
codeboten
approved these changes
Jul 31, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Looks pretty good overall, just some minor comments/suggestions, mostly nits.
instrumentation/opentelemetry-instrumentation-pyramid/README.rst
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-requests/README.rst
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-django/README.rst
Outdated
Show resolved
Hide resolved
ocelotl
approved these changes
Aug 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of [#760]. Renaming web related packages.
Checklist:
changelogs
folder name ext -> subfolder ext
setup.cfg/setup.py
tox
README