Skip to content

Add HTTP user-agent in WSGI instrumentation#964

Merged
lzchen merged 2 commits intoopen-telemetry:masterfrom
jan25:issue-720
Aug 4, 2020
Merged

Add HTTP user-agent in WSGI instrumentation#964
lzchen merged 2 commits intoopen-telemetry:masterfrom
jan25:issue-720

Conversation

@jan25
Copy link
Contributor

@jan25 jan25 commented Aug 2, 2020

Signed-off-by: Abhilash Gnan abhilashgnan@gmail.com

Description

Fixes #720

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@jan25 jan25 requested a review from a team August 2, 2020 09:37
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the PR @jan25, looks like there are some conflicts, happy to merge once they've been resolved

jan25 added 2 commits August 4, 2020 18:03
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
@jan25
Copy link
Contributor Author

jan25 commented Aug 4, 2020

Thanks @codeboten, I merged upstream/master and force pushed. Didn't encounter any conflicts to resolve though. Maybe Github was lying :)

@lzchen lzchen merged commit 57ca703 into open-telemetry:master Aug 4, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
…en-telemetry#964)

* chore: adding metric observable to be able to support async update

* chore: reviews

* chore: reviews

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add HTTP user-agent to WSGI instrumentation

3 participants