Change default redis SpanKind to CLIENT#965
Merged
codeboten merged 2 commits intoopen-telemetry:masterfrom Aug 5, 2020
Merged
Conversation
|
|
akoumjian
force-pushed
the
redis_spankind
branch
from
db9e883 to
b980d1d
Compare
akoumjian
changed the title
lzchen
approved these changes
Aug 3, 2020
Contributor
Author
|
Not sure how to fix that failing test, does not seem related. |
codeboten
suggested changes
Aug 4, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Thanks for the PR! If you could resolve the conflicts, i'm happy to approve and merge.
akoumjian
force-pushed
the
redis_spankind
branch
from
b980d1d to
b3801b1
Compare
Contributor
Author
|
@codeboten Conflicts resolved. |
akoumjian
force-pushed
the
redis_spankind
branch
from
b3801b1 to
b96fa3b
Compare
codeboten
approved these changes
Aug 5, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Thanks for resolving the conflicts!
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
* feat(opentelemetry-exporter-jaeger): http sender * fix: linter * fix(opentelemetry-exporter-jaeger): adds header to avoid infinity loop * test(opentelemetry-exporter-jaeger): verify http sender usage * refactor(opentelemetry-exporter-jaeger): checks if endpoint is setten * feat(opentelemetry-exporter-jaeger): adds nock as dev dependency * test(opentelemetry-exporter-jaeger): adds tests to check req header * fix: tests variable usage * refactor(opentelemetry-exporter-jaeger): removes config parameter change * fix: linter * fix: env var was never called Co-authored-by: Mayur Kale <mayurkale@google.com> Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a tiny change to set the
SpanKindof the redis instrumentor toCLIENT. This is a small semantic change I'm suggesting so that tools which display spans based on SpanKind can show these connections in the correct context.Type of change
Minor enhancement.
How Has This Been Tested?
One test was added to validate the
SpanKindand also added validation forspan.name.Span.SpanKindChecklist: