fix: Make etw logs exporter synchronous#514
Merged
cijothomas merged 2 commits intoopen-telemetry:mainfrom Jan 6, 2026
Merged
Conversation
663aa58 to
f1cdd27
Compare
cijothomas
reviewed
Jan 6, 2026
cijothomas
reviewed
Jan 6, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #514 +/- ##
=======================================
- Coverage 55.8% 55.7% -0.1%
=======================================
Files 77 77
Lines 12500 12472 -28
=======================================
- Hits 6980 6954 -26
+ Misses 5520 5518 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fd011ec to
f7e1357
Compare
Remove block_on calls and remove otel Exporter trait impl.
f7e1357 to
4670659
Compare
cijothomas
approved these changes
Jan 6, 2026
Member
|
@psandana Could you take a look as well before merge? |
psandana
approved these changes
Jan 6, 2026
Contributor
psandana
left a comment
There was a problem hiding this comment.
LGTM. I would include a test that uses block_on() to prevent regressions.
Member
Contributor
Author
|
Yep, will add a test promptly. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove block_on calls and remove otel Exporter trait impl.
Fixes #511
Changes
ETW Logs exporter now does not invoke asynchronous Exporter impl under the hood. The call was a fake (using block_on) anyway, and it could cause problems if, for example, a tracing log macro was called under another block_on() async block - nesting block_on()s is forbidden.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes