Skip to content

test: Nit test addition to otlp#3390

Merged
cijothomas merged 1 commit intoopen-telemetry:mainfrom
cijothomas:cijothomas/otlp-test-nit
Mar 10, 2026
Merged

test: Nit test addition to otlp#3390
cijothomas merged 1 commit intoopen-telemetry:mainfrom
cijothomas:cijothomas/otlp-test-nit

Conversation

@cijothomas
Copy link
Member

Minor test addition.

@cijothomas cijothomas requested a review from a team as a code owner February 25, 2026 04:06
@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.6%. Comparing base (373fc51) to head (e8e424e).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3390   +/-   ##
=====================================
  Coverage   82.6%   82.6%           
=====================================
  Files        128     128           
  Lines      24641   24663   +22     
=====================================
+ Hits       20355   20384   +29     
+ Misses      4286    4279    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cijothomas cijothomas enabled auto-merge March 5, 2026 01:07
@cijothomas
Copy link
Member Author

@scottgerring PTAL.

Copy link
Member

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

I thought we might be able to prevent even expressing this by guarding the enum enumerants against the feature flags, but it is shared between both transport layer choices as well as the env parsing and I think the implicit error there - "this encoding doesn't exist" - is worse.

LGTM

@cijothomas
Copy link
Member Author

Good idea.

I thought we might be able to prevent even expressing this by guarding the enum enumerants against the feature flags, but it is shared between both transport layer choices as well as the env parsing and I think the implicit error there - "this encoding doesn't exist" - is worse.

LGTM

Did you meant to request changes to the PR?

@cijothomas cijothomas added this pull request to the merge queue Mar 10, 2026
Merged via the queue into open-telemetry:main with commit 9bbce12 Mar 10, 2026
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants