Skip to content

fix: add openssl-dev to benchmark container env#3401

Merged
cijothomas merged 1 commit intoopen-telemetry:mainfrom
scottgerring:fix/openssldev
Mar 6, 2026
Merged

fix: add openssl-dev to benchmark container env#3401
cijothomas merged 1 commit intoopen-telemetry:mainfrom
scottgerring:fix/openssldev

Conversation

@scottgerring
Copy link
Member

@scottgerring scottgerring commented Mar 2, 2026

Fixes the benchmark suite. At some point we've made it depend on openssl-dev, but haven't added the dep to the container env.

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.7%. Comparing base (69c62b1) to head (ea63e6b).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3401   +/-   ##
=====================================
  Coverage   82.7%   82.7%           
=====================================
  Files        128     128           
  Lines      24811   24811           
=====================================
  Hits       20526   20526           
  Misses      4285    4285           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scottgerring scottgerring added the bug Something isn't working label Mar 2, 2026
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Hopefully, this is the dev dependency - otherwise we should be using the rustls for TLS handshake.

@cijothomas cijothomas added this pull request to the merge queue Mar 6, 2026
Merged via the queue into open-telemetry:main with commit 8ac4e67 Mar 6, 2026
31 checks passed
@scottgerring scottgerring deleted the fix/openssldev branch March 10, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants