Skip to content

chore(sdk): remove tokio runtime from testing feature#3407

Open
CathalMullan wants to merge 2 commits intoopen-telemetry:mainfrom
CathalMullan:sdk-tokio
Open

chore(sdk): remove tokio runtime from testing feature#3407
CathalMullan wants to merge 2 commits intoopen-telemetry:mainfrom
CathalMullan:sdk-tokio

Conversation

@CathalMullan
Copy link
Contributor

@CathalMullan CathalMullan commented Mar 5, 2026

Related to #2643 I suppose.

Changes

The testing SDK feature doesn't actually need a tokio runtime, it's runtime agnostic, so removed it.

The opentelemetry-appender-log change might look irrelevant, but it's needed since feature unification meant this was previously enabled transitively.

This does mean the naming of the testing types is now a little misleading. They could just be called e.g. TestSpanExporter instead of TokioSpanExporter. Can rename them here if wanted.

EDIT: Actually, since the equivalent metrics type is called TestMetricReader, I'll go ahead with the rename for consistency.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@CathalMullan CathalMullan requested a review from a team as a code owner March 5, 2026 18:27
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.1%. Comparing base (c52f4a3) to head (71e947e).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3407     +/-   ##
=======================================
- Coverage   83.1%   83.1%   -0.1%     
=======================================
  Files        128     128             
  Lines      24877   24877             
=======================================
- Hits       20688   20684      -4     
- Misses      4189    4193      +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@bantonsson bantonsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup @CathalMullan, only one comment about the change log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants