Adding the Metrics Counter API#1578
Merged
SergeyKanzhelev merged 16 commits intoopen-telemetry:mainfrom Mar 30, 2021
Merged
Conversation
reyang
commented
Mar 25, 2021
reyang
commented
Mar 25, 2021
jsuereth
reviewed
Mar 25, 2021
jmacd
approved these changes
Mar 25, 2021
reyang
commented
Mar 25, 2021
bogdandrutu
reviewed
Mar 26, 2021
Member
bogdandrutu
left a comment
bogdandrutu
left a comment
There was a problem hiding this comment.
If I were you I would split this into 2 PRs:
- One that clarifies instrument properties
- One that adds the Counter details
bogdandrutu
reviewed
Mar 26, 2021
cijothomas
reviewed
Mar 26, 2021
cijothomas
reviewed
Mar 26, 2021
cijothomas
reviewed
Mar 27, 2021
noahfalk
reviewed
Mar 27, 2021
|
|
||
| var counterPowerUsed = meter.CreateCounter<double, PowerConsumption>("power_consumption", unit="kWh"); | ||
| counterPowerUsed.Add(13.5, new PowerConsumption { customer = "Tom" }); | ||
| counterPowerUsed.Add(200, new PowerConsumption { customer = "Jerry" }, ("is_green_energy", true)); |
There was a problem hiding this comment.
While I don't anticipate our .NET 6 implementation to include this strongly typed struct capability it does do a good job indicating the kind of flexibility we'd like language implementors to have.
cijothomas
approved these changes
Mar 29, 2021
jsuereth
approved these changes
Mar 29, 2021
Contributor
jsuereth
left a comment
jsuereth
left a comment
There was a problem hiding this comment.
Meta Comment:
Strings in OTel Specification SHOULD be specified somewhere globally and you should just denote that things are strings, referencing that specification. We have a lot off "string" references in the Trace Spec where this spec is far more explicit.
I think it's worth opening a bug to address that and not blocking this PR. That said, not 100% happy with ASCII vs BMP and wanted to understand why.
victlu
reviewed
Mar 30, 2021
lzchen
reviewed
Mar 30, 2021
lzchen
reviewed
Mar 30, 2021
lzchen
reviewed
Mar 30, 2021
Co-authored-by: Leighton Chen <lechen@microsoft.com>
Co-authored-by: Leighton Chen <lechen@microsoft.com>
lzchen
reviewed
Mar 30, 2021
Co-authored-by: Leighton Chen <lechen@microsoft.com>
lzchen
reviewed
Mar 30, 2021
lzchen
approved these changes
Mar 30, 2021
bogdandrutu
approved these changes
Mar 30, 2021
SergeyKanzhelev
approved these changes
Mar 30, 2021
6 tasks
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* counter API * fix link * clarify unit and description * address review comments * avoid money * move the counter creation example to the right place * update the example to avoid anything related to billing/accounting * mention that BMP is basically utf8mb3 * Update specification/metrics/new_api.md Co-authored-by: Leighton Chen <lechen@microsoft.com> * Update specification/metrics/new_api.md Co-authored-by: Leighton Chen <lechen@microsoft.com> * Update specification/metrics/new_api.md Co-authored-by: Leighton Chen <lechen@microsoft.com> * explain why 63 was chosen for unit string length Co-authored-by: Leighton Chen <lechen@microsoft.com> Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
During the 03/18/2021 Metrics API/SDK SIG Meeting, we've agreed to focus on
Counteras the 1st step to tackle the instruments.This will be discussed during the upcoming (3/25) Metrics API/SDK SIG meeting.
Related issues #
Related oteps OTEP146