Add details to Histogram API#1657
Merged
jmacd merged 4 commits intoopen-telemetry:mainfrom May 5, 2021
Merged
Conversation
cijothomas
reviewed
Apr 28, 2021
cijothomas
reviewed
Apr 28, 2021
cijothomas
reviewed
Apr 28, 2021
cijothomas
reviewed
Apr 28, 2021
cijothomas
approved these changes
Apr 28, 2021
Member
cijothomas
left a comment
cijothomas
left a comment
There was a problem hiding this comment.
LGTM.
(left few comments about typos)
ThomsonTan
reviewed
Apr 28, 2021
jsuereth
approved these changes
Apr 28, 2021
SergeyKanzhelev
approved these changes
May 4, 2021
jmacd
approved these changes
May 5, 2021
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* add details to Histogram API * address review comments * update example Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up #1617.
Changes
Added details to the Histogram instrument. In #1617 these were left as TODO.