Skip to content

Define span structure for HTTP retries and redirects#2078

Merged
tigrannajaryan merged 23 commits intoopen-telemetry:mainfrom
denisivan0v:retries-and-redirects
Mar 9, 2022
Merged

Define span structure for HTTP retries and redirects#2078
tigrannajaryan merged 23 commits intoopen-telemetry:mainfrom
denisivan0v:retries-and-redirects

Conversation

@denisivan0v
Copy link
Copy Markdown
Contributor

@denisivan0v denisivan0v commented Oct 28, 2021

Changes

This PR clarifies semantic conventions for HTTP retries and redirects and defines a span structure and linking as well as span attributes for retries. Changes were discussed recently at Instrumentation SIG meetings.

This change addresses a scenario which is in the scope for bringing the existing HTTP semantic conventions for tracing to an initial stable state, see related otep #174.

Comment thread specification/trace/semantic_conventions/http.md Outdated
Comment thread specification/trace/semantic_conventions/http.md Outdated
Comment thread specification/trace/semantic_conventions/http.md Outdated
@github-actions
Copy link
Copy Markdown

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 10, 2021
Comment thread semantic_conventions/trace/http.yaml
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 7, 2021

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Dec 7, 2021
@denisivan0v
Copy link
Copy Markdown
Contributor Author

Do folks know how to reopen this PR? Don't see the reopen button.

@yurishkuro yurishkuro reopened this Dec 7, 2021
@github-actions github-actions bot removed the Stale label Dec 8, 2021
@github-actions
Copy link
Copy Markdown

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 15, 2021
@denisivan0v
Copy link
Copy Markdown
Contributor Author

The implementation of changes proposed in this PR for .NET is done within the PR here opentelemetry-dotnet #2756.

@github-actions github-actions bot removed the Stale label Dec 21, 2021
@github-actions
Copy link
Copy Markdown

This PR was marked stale due to lack of activity. It will be closed in 7 days.

Comment thread specification/trace/semantic_conventions/http.md Outdated
Comment thread specification/trace/semantic_conventions/http.md Outdated
Comment thread specification/trace/semantic_conventions/http.md Outdated
Comment thread specification/trace/semantic_conventions/http.md Outdated
Comment thread specification/trace/semantic_conventions/http.md Outdated
denisivan0v and others added 2 commits February 2, 2022 01:56
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
@github-actions github-actions bot removed the Stale label Feb 2, 2022
Copy link
Copy Markdown
Contributor

@jamesmoessis jamesmoessis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@denisivan0v
Copy link
Copy Markdown
Contributor Author

@tigrannajaryan can you please help merging this PR?

@tigrannajaryan
Copy link
Copy Markdown
Member

This needs to wait for the 2 days cool-down period since the last change.

Comment thread specification/trace/semantic_conventions/http.md
@bogdandrutu
Copy link
Copy Markdown
Member

Merging this as the initial step for this work.

Comment thread specification/trace/semantic_conventions/http.md Outdated
Comment thread specification/trace/semantic_conventions/http.md
@bogdandrutu
Copy link
Copy Markdown
Member

@denisivan0v I swear I tried, but @cijothomas commented before I was able to press the button, and we configured to have all conversations resolved. Please resolve them and I will merge after. you can ping me on slack when everything is resolved.

@tigrannajaryan tigrannajaryan merged commit 5fdeed8 into open-telemetry:main Mar 9, 2022
denisivan0v added a commit to denisivan0v/opentelemetry-dotnet that referenced this pull request Mar 22, 2022
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
…2078)

This PR clarifies semantic conventions for HTTP retries and redirects and defines a span structure and linking as well as span attributes for retries. Changes were discussed recently at Instrumentation SIG meetings.

This change addresses a scenario which is in the scope for bringing the existing HTTP semantic conventions for tracing to an initial stable state, see related [otep open-telemetry#174](open-telemetry/oteps#174).
schmikei pushed a commit to schmikei/opentelemetry-specification that referenced this pull request Apr 17, 2025
…2078)

This PR clarifies semantic conventions for HTTP retries and redirects and defines a span structure and linking as well as span attributes for retries. Changes were discussed recently at Instrumentation SIG meetings.

This change addresses a scenario which is in the scope for bringing the existing HTTP semantic conventions for tracing to an initial stable state, see related [otep open-telemetry#174](open-telemetry/oteps#174).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.