Remove the "MUST" wording which requires exemplar to be on-by-default#2414
Merged
reyang merged 3 commits intoopen-telemetry:mainfrom Mar 15, 2022
Merged
Remove the "MUST" wording which requires exemplar to be on-by-default#2414reyang merged 3 commits intoopen-telemetry:mainfrom
reyang merged 3 commits intoopen-telemetry:mainfrom
Conversation
yurishkuro
approved these changes
Mar 11, 2022
jmacd
approved these changes
Mar 11, 2022
Contributor
jmacd
left a comment
jmacd
left a comment
There was a problem hiding this comment.
I approve this PR with or without the attached, non-blocking suggestion.
cijothomas
approved these changes
Mar 11, 2022
Member
cijothomas
left a comment
cijothomas
left a comment
There was a problem hiding this comment.
the explanation/rationale for this change looks reasonable to me.
arminru
approved these changes
Mar 15, 2022
jmacd
approved these changes
Mar 15, 2022
jack-berg
approved these changes
Mar 15, 2022
Member
jack-berg
left a comment
jack-berg
left a comment
There was a problem hiding this comment.
Approving, but I think exemplars are a really important feature we should strive to stabilize and enable by default in the near future. Want to reiterate this question:
I'd still like to understand criteria for marking Exemplar stable. Specifically, what more do we need to see, what issues exist in the current specification.
8 tasks
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2118, which is considered as a blocking issue for metrics SDK spec stable release.
Changes
We've discussed this during the 3/11/2022 metrics issue triage meeting.
The priority is to ship the stable version of the Metrics SDK spec, however the Exemplar part still has many open questions and there are not sufficient prototype from language SIGs. Here are some decisions we've made in order to move the needles:
This PR removed the "exemplar must be on by default" wording, and used "should be turned off by default" instead. This gives the spec certain room, so later we can change it to "may be turned on by default" or "should be turned on by default" without having to bump the major version of the spec.