Add log attribute limit configuration#2861
Add log attribute limit configuration#2861tigrannajaryan merged 15 commits intoopen-telemetry:mainfrom
Conversation
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
arminru
added
area:sdk
|
I believe we reached agreement on the naming question of @open-telemetry/specs-logs-approvers please take a look. edit |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
This includes changes to trace sdk file. Either fix the the PR description to explain why it is in one PR with the log limits or split into 2 separate PRs if unrelated. |
|
@open-telemetry/specs-approvers please review. |
There was a problem hiding this comment.
This includes changes to trace sdk file. Either fix the the PR description to explain why it is in one PR with the log limits or split into 2 separate PRs if unrelated.
I'm fine splitting the changes to the trace SDK into a separate PR. Though, the corresponding sections of log and trace SDK should mirror each other. I think it makes sense to make the changes in trace and log specs in parallel to eliminate the possibility of continued divergence.
Below is my thought process for each of the changes I've made to the trace SDK.
alanwest
changed the title
alanwest
changed the title
|
Has enough approvals, 2 days passed since last change, merging. |
Fixes open-telemetry#2860 Adds log attribute limit configuration. These new environment variables bring more consistency between spans and logs.
Fixes open-telemetry#2860 Adds log attribute limit configuration. These new environment variables bring more consistency between spans and logs.
Fixes open-telemetry#2860 Adds log attribute limit configuration. These new environment variables bring more consistency between spans and logs.
8 participants
Fixes #2860
Adds log attribute limit configuration.
These new environment variables bring more consistency between spans and logs. Therefore, I believe it should be exempt from the moratorium on new env vars.