Skip to content

Update Apache HTTP Server access log example mapping#3114

Merged
reyang merged 7 commits intoopen-telemetry:mainfrom
pellared:cleanup
Feb 7, 2023
Merged

Update Apache HTTP Server access log example mapping#3114
reyang merged 7 commits intoopen-telemetry:mainfrom
pellared:cleanup

Conversation

@pellared
Copy link
Copy Markdown
Member

@pellared pellared commented Jan 19, 2023

Why

Cleanup after: #2614, #2469

Discovered when reviewing: #3087

What

Update Apache HTTP Server access log example mapping to match current semantic conventions.

@pellared pellared requested review from a team January 19, 2023 11:13
@pellared
Copy link
Copy Markdown
Member Author

@lmolkova PTAL

Copy link
Copy Markdown
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@arminru arminru added spec:logs Related to the specification/logs directory area:data-model For issues related to data model labels Jan 31, 2023
Comment thread specification/logs/data-model.md Outdated
Comment thread specification/logs/data-model.md Outdated
Copy link
Copy Markdown
Member Author

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arminru Thanks for your review. Can you take a quick look at my suggestions?

Comment thread specification/logs/data-model.md Outdated
Comment thread specification/logs/data-model.md Outdated
@pellared
Copy link
Copy Markdown
Member Author

pellared commented Feb 7, 2023

@open-telemetry/specs-approvers Is it good to merge? 😉

@reyang reyang merged commit 26e98fc into open-telemetry:main Feb 7, 2023
@pellared pellared deleted the cleanup branch February 8, 2023 08:00
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:data-model For issues related to data model spec:logs Related to the specification/logs directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants