Rename http.user_agent to user_agent.original#3190
Merged
carlosalberto merged 15 commits intoopen-telemetry:mainfrom Mar 2, 2023
Merged
Rename http.user_agent to user_agent.original#3190carlosalberto merged 15 commits intoopen-telemetry:mainfrom
carlosalberto merged 15 commits intoopen-telemetry:mainfrom
Conversation
trask
force-pushed
the
user-agent
branch
2 times, most recently
from
87e986c to
00cbb2f
Compare
trask
changed the title
trask
added
area:semantic-conventions
reyang
approved these changes
Feb 14, 2023
arminru
reviewed
Feb 14, 2023
MSNev
approved these changes
Feb 14, 2023
Contributor
|
Do we want to include removal / renaming of |
Member
Author
@MSNev I added to this PR, ptal 👍 |
MSNev
approved these changes
Feb 14, 2023
carlosalberto
approved these changes
Feb 15, 2023
Member
|
Fix submitted to build tools: open-telemetry/build-tools#138 |
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-specification
that referenced
this pull request
Feb 27, 2023
build-tools 1.16.0 was just released and is necessary to unblock open-telemetry#3190
Member
|
Here is the PR to update to latest build-tools which includes the fix to schema check tool: #3259 Once that is merged this PR needs to be rebased. |
tigrannajaryan
added a commit
that referenced
this pull request
Feb 27, 2023
build-tools 1.16.0 was just released and is necessary to unblock #3190
Member
|
This can be rebased now and the schema check should pass. |
Member
Author
|
@tigrannajaryan thx for fixing this, schema check is passing now. can you remove your "request changes"? thx! |
jsuereth
pushed a commit
to jsuereth/opentelemetry-specification
that referenced
this pull request
Feb 28, 2023
build-tools 1.16.0 was just released and is necessary to unblock open-telemetry#3190
Contributor
|
@trask Conflicts need to be solved but otherwise (it sounds like) we are ready to merge this. |
Contributor
|
Merging after letting this PR settle and get some more attention. |
jsuereth
pushed a commit
to jsuereth/otel-semconv-test
that referenced
this pull request
Apr 19, 2023
build-tools 1.16.0 was just released and is necessary to unblock open-telemetry/opentelemetry-specification#3190
jsuereth
pushed a commit
to open-telemetry/semantic-conventions
that referenced
this pull request
May 11, 2023
build-tools 1.16.0 was just released and is necessary to unblock open-telemetry/opentelemetry-specification#3190
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
build-tools 1.16.0 was just released and is necessary to unblock open-telemetry#3190
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Fixes open-telemetry#3180 ## Changes Renames `http.user_agent` to `user_agent.original`.
apollo0202
pushed a commit
to apollo0202/conventions-semantic
that referenced
this pull request
Mar 1, 2025
build-tools 1.16.0 was just released and is necessary to unblock open-telemetry/opentelemetry-specification#3190
schmikei
pushed a commit
to schmikei/opentelemetry-specification
that referenced
this pull request
Apr 17, 2025
Fixes open-telemetry#3180 ## Changes Renames `http.user_agent` to `user_agent.original`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3180
Changes
Renames
http.user_agenttouser_agent.original.