BREAKING: Rename remaining network attributes from net.* to network.* and align definitions with ECS#3426
Conversation
0f1bfc7 to
c1133b8
Compare
c1133b8 to
50d2c10
Compare
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
|
I wonder if this impacts our ebpf implementation. @open-telemetry/ebpf-maintainers @open-telemetry/ebpf-approvers can you comment? Is this a breaking change from your perspective? |
|
This is not a breaking change for opentelemetry-ebpf because it does not currently emit any metrics defined in the opentelemetry-specification (although that should probably change). Instead, it uses historical metric names documented here: https://github.com/open-telemetry/opentelemetry-ebpf/blob/main/docs/metrics/metrics.yaml. |
|
After a long discussion, +1. I feel like this really clarifies some very confusing x-layer attributes we had previously. |
2f54833 to
6636dac
Compare
Can you clarify what you mean by this? |
I believe what he liked was that the attributes are now defined in terms of OSI layers. |
|
|
|
good to go! |
…k.*` and align definitions with ECS (open-telemetry#3426)
…k.*` and align definitions with ECS (open-telemetry#3426)
…k.*` and align definitions with ECS (open-telemetry#3426)
…k.*` and align definitions with ECS (open-telemetry#3426)
Fixes #3371
Fixes #3438
Changes
Introduce:
network.transportdefined as OSI Transport Layer or Inter-process Communication method.network.typedefined as OSI Network Layer or non-OSI equivalent.(note: ECS defines both
network.transportandnetwork.typeonly in terms of OSI, but we expand the definition here to be more general)Remove
net.transportandnet.sock.family.Rename:
net.protocol.*-->network.protocol.*net.host.connection.*-->network.connection.*net.host.carrier.*-->network.carrier.*Summary of benefits
More precise definition of
network.transportandnetwork.typein terms of OSI model where applicable.These attributes are used in ECS security use cases, so the cost of breaking these on the ECS side is higher, while these remaining
net.*attributes are not heavily used in OpenTelemetry instrumentation (and we can bundle this into the transition plan for the larger breaking changes).We can bring in the remaining ECS
network.*attributes without causing ECS more breakage.