Tracers should reference an InstrumentationLibrary rather than a Resource#616
Merged
bogdandrutu merged 1 commit intoopen-telemetry:masterfrom May 21, 2020
Conversation
mwear
requested review from
SergeyKanzhelev,
arminru,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
jmacd,
reyang,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
Contributor
|
I'm curious how this squares with open-telemetry/opentelemetry-proto#150 |
jkwatson
approved these changes
May 20, 2020
Member
Author
|
@jmacd This was discussed briefly in #614. This PR will make the spec accurate as far as the current state of things is concerned. When open-telemetry/opentelemetry-proto#150 merges there will be another round of changes required. |
bogdandrutu
approved these changes
May 20, 2020
reyang
approved these changes
May 21, 2020
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #614.
The tracer creation portion of the trace SDK spec specifies that the name and version used to obtain a tracer should be stored on a
Resourceobject and made available through agetLibraryResourcemethod. With the introduction of OTEP-83, this is no longer accurate. The name and version should be represented as anInstrumentationLibraryinstance instead.See #614 for more discussion.