Skip to content

Metrics terminology (Adding/Grouping)#983

Merged
arminru merged 8 commits intoopen-telemetry:masterfrom
jmacd:jmacd/625
Sep 25, 2020
Merged

Metrics terminology (Adding/Grouping)#983
arminru merged 8 commits intoopen-telemetry:masterfrom
jmacd:jmacd/625

Conversation

@jmacd
Copy link
Copy Markdown
Contributor

@jmacd jmacd commented Sep 22, 2020

Changes

Apply #625 decision to the API spec: The term "Additive" is replaced by "Adding", and "Non-Additive" is replaced by "Grouping". See the comment here.

Fixes #625.

@jmacd jmacd added the spec:metrics Related to the specification/metrics directory label Sep 22, 2020
@jmacd jmacd requested review from a team September 22, 2020 07:08
Thank you @jkwatson.

Co-authored-by: John Watson <jkwatson@gmail.com>
@bogdandrutu
Copy link
Copy Markdown
Member

Please rebase

jmacd and others added 3 commits September 24, 2020 13:25
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
@jmacd
Copy link
Copy Markdown
Contributor Author

jmacd commented Sep 25, 2020

This is ready to merge.

@arminru arminru merged commit 7561ec6 into open-telemetry:master Sep 25, 2020
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Co-authored-by: John Watson <jkwatson@gmail.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

spec:metrics Related to the specification/metrics directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metrics terminology: Grouping instruments as (opposed to Adding instruments)

6 participants