-
Notifications
You must be signed in to change notification settings - Fork 339
Add policy to check that attribute does not change the type during/after deprecation. #1369
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't workingtoolingRegarding build, workflows, build-tools, ...Regarding build, workflows, build-tools, ...
Description
In #913 (released with v1.26.0) we
- deprecated
messaging.operationin favor ofmessaging.operation.type - changed its type from enum (of strings) to string
As a result generated code no longer produces enum for old messaging operations which is a breaking change.
We do have a back-compat check for attribute types, but it applies to stable attributes only (messaging.* is experimental).
We do allow changing type of experimental attributes, i.e. semconv artifacts that include experimental conventions MUST be experimental.
If we just changed the type, there would be nothing(?) we could do to prevent breaking. Perhaps we could have some notification mechanism?
But we also deprecated the attribute, so we can expand our back-compat validation to deprecated attributes as well - this will preserve enums and their values.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingtoolingRegarding build, workflows, build-tools, ...Regarding build, workflows, build-tools, ...
Type
Projects
Status
No status