Make url.query conditionally required for HTTP spans#118
Merged
reyang merged 2 commits intoopen-telemetry:mainfrom Jun 19, 2023
Merged
Make url.query conditionally required for HTTP spans#118reyang merged 2 commits intoopen-telemetry:mainfrom
url.query conditionally required for HTTP spans#118reyang merged 2 commits intoopen-telemetry:mainfrom
Conversation
lmolkova
approved these changes
Jun 16, 2023
Member
|
mind adding a changelog entry? |
mateuszrzeszutek
approved these changes
Jun 19, 2023
Oberon00
approved these changes
Jun 19, 2023
reyang
approved these changes
Jun 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112
Aligns the requirement level of
url.querywith the requirement level ofurl.path.It was also the previous behavior when those two attributes were combined in the single field
http.target, and appears to have been a bug that slipped into open-telemetry/opentelemetry-specification#3355 when that field was split intourl.pathandurl.query.