[chore] uncomment device.app.lifecycle event definition#1461
[chore] uncomment device.app.lifecycle event definition#1461lmolkova merged 3 commits intoopen-telemetry:mainfrom
Conversation
9fccb96 to
d306d6e
Compare
d306d6e to
ae55bc6
Compare
Then this cannot be merged, right? Because there are still SIGs that haven't yet migrated to Weaver: open-telemetry/weaver#227 |
|
@joaopgrassi that's a great point! I agree we should not add features that break build-tools until the migration is finished I just checked if build-tools will fail on this change and it doesn't - lmolkova/opentelemetry-python#3 Build-tools has a mode to ignore validation errors - for this one it warns with As a result, nobody can generate event bodies with build-tools, but that's a new feature and nobody generated them in the past (and won't be able to). BTW we still have a CI check - |
Now that Semantic Conventions supports
eventyaml definitions, this PR is uncommenting thedevice.app.lifecycleevent definition so that it is defined in yaml and ready for markdown generation.Note: Once committed this will block anyone consuming the updated SemConv version that has not yet migrated to using weaver.