add k8s.container.status.state and k8s.container.status.reason metrics#1784
Merged
lmolkova merged 7 commits intoopen-telemetry:mainfrom May 29, 2025
Merged
add k8s.container.status.state and k8s.container.status.reason metrics#1784lmolkova merged 7 commits intoopen-telemetry:mainfrom
lmolkova merged 7 commits intoopen-telemetry:mainfrom
Conversation
povilasv
force-pushed
the
container-status
branch
4 times, most recently
from
8de6ad2 to
726203e
Compare
ChrsMark
reviewed
Jan 22, 2025
povilasv
force-pushed
the
container-status
branch
from
726203e to
6923556
Compare
ChrsMark
reviewed
Jan 27, 2025
trask
reviewed
Jan 29, 2025
trask
reviewed
Jan 30, 2025
jinja2
reviewed
Jan 30, 2025
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
This PR was auto closed but I feel that this change would be useful (at least, for me, and there are 2 issues open for this) Can this be re-opened? Is there anything I can do to help? |
Contributor
Author
|
Sorry got side tracked by other tasks, will try take a look at the feedback next week and see if we can push this forward :) |
|
I totally understand :) Thank you |
povilasv
force-pushed
the
container-status
branch
3 times, most recently
from
134c08f to
2d7e2dd
Compare
jinja2
approved these changes
May 13, 2025
jinja2
reviewed
May 13, 2025
jinja2
reviewed
May 13, 2025
povilasv
force-pushed
the
container-status
branch
from
5d51a46 to
98d6186
Compare
iblancasa
approved these changes
May 16, 2025
dashpole
approved these changes
May 16, 2025
lmolkova
reviewed
May 16, 2025
lmolkova
approved these changes
May 23, 2025
lmolkova
reviewed
May 23, 2025
Co-authored-by: Christos Markou <chrismarkou92@gmail.com>
Co-authored-by: Jina Jain <jjain@splunk.com>
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
povilasv
force-pushed
the
container-status
branch
from
bd59bd0 to
bf2f0f7
Compare
jherbage
pushed a commit
to jherbage/semantic-conventions
that referenced
this pull request
Jul 1, 2025
open-telemetry#1784) Co-authored-by: Christos Markou <chrismarkou92@gmail.com> Co-authored-by: Jina Jain <jjain@splunk.com> Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1672
Changes
Adds
k8s.container.status.statemetric, it would allow us to alert and monitor containers in not ready state.I'm still not sure if this should be multiple different metrics or a single one 🤔
The current problems, with single metric:
Waiting state - "ContainerCreating", "CrashLoopBackOff", "CreateContainerConfigError", "ErrImagePull", "ImagePullBackOff"
Terminated state - "OOMKilled", "Completed", "Error", "ContainerCannotRun"
Alternative approach would be to do what KSM does:
k8s.container.status.statemetric withoutreasonattribute.k8s.container.status.waiting_reasonmetric for waiting reason enum.k8s.container.status.terminated_reasonmetric for terminated reason enum.This is not intended to merge, I would appreciate any feedback to see what we want to do here.
Merge requirement checklist
[chore]