Skip to content

Update weaver to 0.14.0 and allow _ -> . renames#2086

Merged
lmolkova merged 3 commits intoopen-telemetry:mainfrom
lmolkova:update-weaver
Apr 11, 2025
Merged

Update weaver to 0.14.0 and allow _ -> . renames#2086
lmolkova merged 3 commits intoopen-telemetry:mainfrom
lmolkova:update-weaver

Conversation

@lmolkova
Copy link
Member

@lmolkova lmolkova commented Apr 11, 2025 •
edited
Loading

Related to #1118 and #1982

The new weaver supports excluding attributes from code generation allowing us to rename foo_bar to foo.bar!
It can be done by providing the following annotation on attribute to be excluded:

- id: messaging.client_id
  ....
  annotations:
    code_generation:
      exclude: true

@lmolkova lmolkova requested review from a team as code owners April 11, 2025 00:59
@lmolkova lmolkova added the Skip Changelog Label to skip the changelog check label Apr 11, 2025
lmolkova
lmolkova commented Apr 11, 2025
View reviewed changes
This was referenced Apr 11, 2025
Merged
Open
trask
trask approved these changes Apr 11, 2025
View reviewed changes
@lmolkova lmolkova moved this from Untriaged to Needs More Approval in Semantic Conventions Triage Apr 11, 2025
lquerel
lquerel approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@lmolkova lmolkova requested review from a team as code owners April 11, 2025 16:28
@lmolkova lmolkova merged commit 37aa277 into open-telemetry:main Apr 11, 2025
14 checks passed
lmolkova pushed a commit to lmolkova/semantic-conventions that referenced this pull request May 13, 2025
Update weaver to 0.14.0 and allow _ -> . renames (open-telemetry#…
a87b349 
…2086)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trask trask trask approved these changes

@lquerel lquerel lquerel approved these changes

Assignees

No one assigned

Labels

Skip Changelog Label to skip the changelog check

Projects

Semantic Conventions Triage
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lmolkova @trask @lquerel