Conversation
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
:) Yeap I think we should treat it as a Metric. example: ➜ semantic-conventions git:(add_host_cpu_info) cat /proc/cpuinfo | grep MHz
cpu MHz : 3000.000
cpu MHz : 1054.524
cpu MHz : 1093.029
cpu MHz : 3000.000
cpu MHz : 3000.000
cpu MHz : 3000.000
cpu MHz : 3000.000
cpu MHz : 3000.000
➜ semantic-conventions git:(add_host_cpu_info) cat /proc/cpuinfo | grep MHz
cpu MHz : 1467.399
cpu MHz : 3000.000
cpu MHz : 3000.000
cpu MHz : 3000.000
cpu MHz : 3000.000
cpu MHz : 3000.000
cpu MHz : 2462.027
cpu MHz : 3000.000 |
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
|
@AlexanderWert mind taking another look? |
joaopgrassi
left a comment
There was a problem hiding this comment.
Please add a changelog entry
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Co-authored-by: Joao Grassi <joao@joaograssi.com>
|
@ChrsMark make sure to resolve the discussions if you think they are resolved (if not then ask the persons if you can resolve). That would help others to see if this is in a final state or not. |
|
Thanks @joaopgrassi, based on the latest discussions/approvals all those are resolved. Marked them properly. |
|
@joaopgrassi @AlexanderWert anything else missing here? |
|
@open-telemetry/specs-semconv-maintainers I think we are good to merge this |
|
@open-telemetry/specs-semconv-approvers @open-telemetry/specs-semconv-maintainers we discussed this in the System semconv SIG and should be good to go. Will give it another day, but if nothing then I will merge. |
This PR adds CPU information as proposed with #130.
The CPU related information go under the
host.cpunamespace.