Skip to content

Fix System metrics yaml warning#322

Merged
joaopgrassi merged 1 commit intoopen-telemetry:mainfrom
dynatrace-oss-contrib:fix-system-metricsy-yaml
Sep 13, 2023
Merged

Fix System metrics yaml warning#322
joaopgrassi merged 1 commit intoopen-telemetry:mainfrom
dynatrace-oss-contrib:fix-system-metricsy-yaml

Conversation

@joaopgrassi
Copy link
Copy Markdown
Member

I noticed a warning in PRs related to the recently merged #89 yaml model for system metrics. I left a misaligned comment and GitHub UI complains about it:

image

@joaopgrassi joaopgrassi requested review from a team September 13, 2023 10:41
@joaopgrassi joaopgrassi changed the title Fix System metrics yaml warnings Fix System metrics yaml warning Sep 13, 2023
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@joaopgrassi joaopgrassi merged commit e880bdd into open-telemetry:main Sep 13, 2023
@joaopgrassi joaopgrassi deleted the fix-system-metricsy-yaml branch September 13, 2023 11:11
trask pushed a commit to trask/semantic-conventions that referenced this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants