Generate process metrics with semconv yaml#330
Generate process metrics with semconv yaml#330joaopgrassi merged 15 commits intoopen-telemetry:mainfrom
semconv yaml#330Conversation
|
I am unable to assign reviewers, these are the folks who commented on the previous PR. @joaopgrassi @mx-psi @jsuereth |
|
Needs minor edits for CI to pass but content LGTM |
Thanks @mx-psi those are fixed now, also added something to |
|
Looks like these workflows require approval now if someone can press the button for me. 😄 |
ChrsMark
left a comment
There was a problem hiding this comment.
Content-wise lgtm!
@braydonk please file an issue for #330 (comment) so as to examine #260 as well :).
|
Thanks, I'll file an issue today and I'll put my thoughts on #260 in there! |
|
I will try to take a look at it today or tomorrow! |
cc24409 to
5ad3a95
Compare
|
Sorry for the force-push, I should have merged instead of rebasing to update the branch. Force of habit |
|
It's possible I'm missing some kind of context from discussions around #51, but it seems like what I have here should be fine. With the paging fault type attribute for example: it is in the If I'm indeed missing some extra guidance that's not present in #51, and this attribute should go to |
The thing I'm not sure is that CC @open-telemetry/specs-semconv-approvers @open-telemetry/specs-semconv-maintainers Edit: There's also this old issue which I think is related and was never closed with a decision #50 |
e10cc9a to
c6db7c5
Compare
|
I have updated the PR to match the semantic convention guidance as well as I'm able. I renamed the metrics that are |
0ecb60a to
e88fe68
Compare
Fixes linting errors, also adds the `ignore-from-file` configuration the the `.yamllint` to avoid scanning `node_modules` locally.
in progress 2 in progress 3
Rename metrics that are updowncounters to use the `.count` naming convention. Also rename attributes to not use metric names as namespaces.
disk.io.direction and network.io.direction were added to the global registry, so this commit uses references to those attributes.
e88fe68 to
d971697
Compare
|
I added Do not merge until I've added these back to the main files. |
joaopgrassi
left a comment
There was a problem hiding this comment.
LGTM after fixing the CI issues
ChrsMark
left a comment
There was a problem hiding this comment.
LGTM. Let's make sure that we file an issue for moving the attributes to the registry: #330 (comment)
Opened #650 to track this. |
|
This should be ready for merge. |
|
I will bring this up in the semconv SIG meeting today, to raise awareness. I guess we can merge it then later today/tomorrow if no objections. |
Supplants #160
Changes
This PR adds a yaml version of the process metrics and changes the process metrics documentation to be generated from the yaml instead of hand-written.
Merge requirement checklist