Clarify how to report the total amount of memory#409
Merged
AlexanderWert merged 10 commits intoopen-telemetry:mainfrom Oct 27, 2023
Merged
Clarify how to report the total amount of memory#409AlexanderWert merged 10 commits intoopen-telemetry:mainfrom
AlexanderWert merged 10 commits intoopen-telemetry:mainfrom
Conversation
f0d46c3 to
b862a39
Compare
b862a39 to
aac8c7e
Compare
ChrsMark
reviewed
Oct 17, 2023
jsuereth
approved these changes
Oct 19, 2023
Contributor
jsuereth
left a comment
There was a problem hiding this comment.
Can you open a bug to provide a mechanism in Schema-Files to denote an attribute being dropped?
Yes, it's a breaking change, we're actually going to try to encode breaking changes in SCHEMA over time.
Member
Author
#1054 is related (although it refers to a different instance where the values were renamed, not dropped). Does that work? Or should we file a new one? |
Member
|
I think this can be a non-breaking change:
We can define a |
joaopgrassi
reviewed
Oct 23, 2023
joaopgrassi
reviewed
Oct 24, 2023
joaopgrassi
approved these changes
Oct 27, 2023
ChrsMark
approved these changes
Oct 27, 2023
dmitryax
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jan 5, 2024
Adds opt-in support for `system.memory.limit`, standardized on open-telemetry/semantic-conventions/pull/409.
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
…#30306) Adds opt-in support for `system.memory.limit`, standardized on open-telemetry/semantic-conventions/pull/409.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates open-telemetry/build-tools#127
Changes
totalfrom list of well-known values forsystem.memory.statesystem.memory.usageclarifying that adding oversystem.memory.stateSHOULD equal the total amount of memory available in the system.system.memory.limitmetric that reports the total amount of memory available in the system.This tries to follow the guidance on https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/metrics.md#instrument-naming:
and
The
totalvalue was added on open-telemetry/build-tools#89 but was not listed before the refactoring. This rewording avoids an inconsistency with the general guidelines and adds a metric that may be useful in some implementations given that total is reported separately by certain OSs (e.g. Linux).Merge requirement checklist