Skip to content

Align system.cpu.state's definition with this of process.cpu.state#765

Merged
arminru merged 2 commits intoopen-telemetry:mainfrom
ChrsMark:add_cpu_state_constraint
Mar 11, 2024
Merged

Align system.cpu.state's definition with this of process.cpu.state#765
arminru merged 2 commits intoopen-telemetry:mainfrom
ChrsMark:add_cpu_state_constraint

Conversation

@ChrsMark
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark commented Feb 23, 2024

Fixes #563

Changes

This PR aligns the definition of the system.cpu.state's with this of process.cpu.state. Specifically it adds the same constraint of process.cpu.states as mentioned at #563 (comment).

Merge requirement checklist

@ChrsMark ChrsMark self-assigned this Feb 23, 2024
@ChrsMark ChrsMark requested review from a team February 23, 2024 13:06
@ChrsMark ChrsMark force-pushed the add_cpu_state_constraint branch from d6a568b to b0e5ccb Compare February 23, 2024 13:10
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark force-pushed the add_cpu_state_constraint branch from b0e5ccb to e1b11b6 Compare February 23, 2024 13:46
@joaopgrassi
Copy link
Copy Markdown
Member

Shouldn't we instead move the attribute to the registry, and simply re-use it in process/system metrics? There's also this which is related #681

@ChrsMark
Copy link
Copy Markdown
Member Author

ChrsMark commented Mar 4, 2024

Thank's @joaopgrassi for pointing to this. Check #765 (comment).

@arminru arminru merged commit 3edef61 into open-telemetry:main Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Is possible to align process.cpu.time,utilization metrics defintion to system.cpu.time,utilization

6 participants