Align system.cpu.state's definition with this of process.cpu.state#765
Merged
arminru merged 2 commits intoopen-telemetry:mainfrom Mar 11, 2024
Merged
Conversation
d6a568b to
b0e5ccb
Compare
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
b0e5ccb to
e1b11b6
Compare
trask
approved these changes
Feb 26, 2024
jsuereth
approved these changes
Feb 28, 2024
Member
|
Shouldn't we instead move the attribute to the registry, and simply re-use it in process/system metrics? There's also this which is related #681 |
2 tasks
Member
Author
|
Thank's @joaopgrassi for pointing to this. Check #765 (comment). |
joaopgrassi
approved these changes
Mar 4, 2024
mx-psi
approved these changes
Mar 11, 2024
arminru
approved these changes
Mar 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #563
Changes
This PR aligns the definition of the
system.cpu.state's with this ofprocess.cpu.state. Specifically it adds the same constraint ofprocess.cpu.statesas mentioned at #563 (comment).Merge requirement checklist
[chore]