Skip to content

Rename db.statement to db.query.text and introduce db.query.parameter.<key>#866

Merged
lmolkova merged 15 commits intoopen-telemetry:mainfrom
trask:db-query-namespace
Apr 8, 2024
Merged

Rename db.statement to db.query.text and introduce db.query.parameter.<key>#866
lmolkova merged 15 commits intoopen-telemetry:mainfrom
trask:db-query-namespace

Conversation

@trask
Copy link
Copy Markdown
Member

@trask trask commented Apr 2, 2024

Fixes #716

Changes

Renames db.statement to db.query.text and introduces db.query.parameter.<key>.

Merge requirement checklist

@trask trask marked this pull request as ready for review April 2, 2024 02:15
@trask trask requested review from a team April 2, 2024 02:15
Copy link
Copy Markdown
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (if db.statement is deprecated )

@trask trask force-pushed the db-query-namespace branch from e6102ca to b045d44 Compare April 2, 2024 14:27
@trask trask requested a review from gregkalapos April 5, 2024 15:34
@lmolkova lmolkova merged commit b5b2409 into open-telemetry:main Apr 8, 2024
@trask trask deleted the db-query-namespace branch October 14, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add attribute db.values to database semantic conventions

9 participants