[chore] Move system metric attributes to the registry#867
[chore] Move system metric attributes to the registry#867joaopgrassi merged 8 commits intoopen-telemetry:mainfrom
Conversation
Add sub-sections
Add <!-- toc -->
Add deprecated attribtutes to the list.
7db66a0 to
893c4e6
Compare
There was a problem hiding this comment.
Not sure if the state of this PR is "ready for review" already but my comment seems to be still unresolved?
I think we have concluded on having the registry in a signal generic form. In this I left some suggestions to remove any mention to "Metrics" from the registry's attributes.
And we will still need to override the system.cpu.state within the system metrics spec.
Let me know @gregkalapos if I miss anything or there is anything that is unclear ;).
Sorry for the confusion - let's discussed it in that thread and depending on what we agree on, I'll move on with the suggestions. |
Co-authored-by: Chris Mark <chrismarkou92@gmail.com>
ChrsMark
left a comment
There was a problem hiding this comment.
Thank's @gregkalapos! Looks good from my side.
Changes
Moves
system.*attributes to the registry from system metrics.Merge requirement checklist
[chore]