[metrics/system] Remove shared from system.memory.state values#933
Merged
lmolkova merged 5 commits intoopen-telemetry:mainfrom Apr 30, 2024
Merged
Conversation
ChrsMark
force-pushed
the
decouple_shared_memory_metric
branch
from
8f3f66e to
fcbab37
Compare
mx-psi
approved these changes
Apr 25, 2024
Member
mx-psi
left a comment
mx-psi
left a comment
There was a problem hiding this comment.
LGTM, at a first glance I don't think this kind of change is possible to express in the telemetry schema
lmolkova
reviewed
Apr 26, 2024
lmolkova
reviewed
Apr 26, 2024
ChrsMark
force-pushed
the
decouple_shared_memory_metric
branch
from
0b4b92d to
b59e2d7
Compare
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
ChrsMark
force-pushed
the
decouple_shared_memory_metric
branch
2 times, most recently
from
994c13a to
d24df00
Compare
Member
Author
|
Thank's @lmolkova ! I have addressed your comments. Please take another look. |
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
ChrsMark
force-pushed
the
decouple_shared_memory_metric
branch
from
d24df00 to
fa32823
Compare
trisch-me
approved these changes
Apr 29, 2024
lmolkova
reviewed
Apr 30, 2024
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
jsuereth
approved these changes
Apr 30, 2024
drewby
pushed a commit
to drewby/otel-semantic-conventions
that referenced
this pull request
May 23, 2024
…telemetry#933) Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #522
Changes
This PR removes the
sharedstate from the possible values of thesystem.memory.statemetric since it does not contribute to the total. The attribute guidelines mention though:Hence, we need to remove this state and make it standalone metric.
Merge requirement checklist
[chore]Note: I'm not sure if schema-next.yaml needs to be updated since the PR only touches the values' set 🤔